[coreboot-gerrit] Change in coreboot[master]: volteer: Create lindar variant

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )

Change subject: volteer: Create lindar variant
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:

https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... 
PS8, Line 9: /* Copied from baseboard and may need to change for the new variant. */
> i would also prefer to see the auto-generated changes as a separate patch […]

IMHO, when adding a new board, the first commit should be able to make it boot. I'm not going to block this from going in as separate commits, but I'd prefer to do it in a single commit.

Plus, there's dependencies between GPIO and devicetree settings: e.g. if UART 1 is enabled, its pins need to use the UART native function and can't be used as GPIOs. Having separate patches for GPIO and devicetree settings makes it harder to compare both.