Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44295 )
Change subject: cpu/amd/agesa: Use common MRC_CACHE code to save S3 data
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44295/comment/3d83befe_fd57372c
PS8, Line 11: is not rewritten all the time. This prolongs the hardware's life.
AMDFW_OUTSIDE_CBFS option may be obsolete or unused, expect for ChromeOS and stoneyridge -combination. Adding FMAP regions could introduce a conflict with HUDSON_FWM_POSITION in some configuration combinations.
Isnt stoneyridge handled in soc/amd instead of here? Stoneyridge already use MRC_CACHE fmap afaict
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f4f36dcead52a6c550fb5e606772e0a99029872
Gerrit-Change-Number: 44295
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@tutanota.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 18 May 2022 11:09:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment