Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45278 )
Change subject: WIP: Use SPDs from PSP BIOS table type 0x69 based on GPIO straps ......................................................................
Patch Set 1:
(3 comments)
I suspect you're going to need a phased approach and that may be why your Jenkins builds are failing. Maybe add the capability to amdfwtool and Makefile.inc, change the mainboards, then obsolete the old behavior.
https://review.coreboot.org/c/coreboot/+/45278/1/src/soc/amd/picasso/Makefil... File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45278/1/src/soc/amd/picasso/Makefil... PS1, Line 396: : Spaces here and on l.399
https://review.coreboot.org/c/coreboot/+/45278/1/src/soc/amd/picasso/Makefil... PS1, Line 443: : echo $(AMDFWTOOL) \ : $(OPT_PSPBTLDR_FILE) \ : $(AMDFW_COMMON_ARGS) \ : $(OPT_APOB0_NV_SIZE) \ : $(OPT_APOB0_NV_BASE) \ : $(OPT_VERSTAGE_FILE) \ : $(OPT_VERSTAGE_SIG_FILE) \ : --location $(shell printf "%#x" $(PICASSO_FWM_POSITION)) \ : --output $@ We probably want to omit this. We should be able to get the same info by running "make V=1". If you really intend to change the info printed during the build, it should be in a separate patch since it's unrelated.
https://review.coreboot.org/c/coreboot/+/45278/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/45278/1/util/amdfwtool/amdfwtool.c@... PS1, Line 218: Convert tabs to spaces