Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47259 )
Change subject: soc/intel/tigerlake: Update Kconfig for NEM Enhanced Mode
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47259/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47259/7//COMMIT_MSG@9
PS7, Line 9: Added change to select COS_MAPPED_TO_MSB if INTEL_CAR_NEM_ENHANCED
: is selected in Tigerlake soc Kconfig.
I think it would be good to add some more details explaining why this change is being made and how this will change again once things are better understood after SF_MASK. Also, are you planning on adding the Kconfigs as discussed here: b/172592700
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6e041261cb8ca9c6e602935da4962aac0d9ece5
Gerrit-Change-Number: 47259
Gerrit-PatchSet: 7
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Comment-Date: Fri, 06 Nov 2020 17:06:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment