[coreboot-gerrit] Change in coreboot[master]: src/device/pci: Add support for discrete VGA initialization and OpROM...

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )

Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading
......................................................................

Patch Set 20:

(1 comment)
> Patch Set 1:
>
> The Kconfig option seems useless.
>
> Can't you simply write two VFCT acpi tables ? Looking at the code that be possible.
>
> Is it safe to load / run two option ROMs ? I'd only load the primary one.
>
> This patch should be split into two parts: One for providing multiple VFCT tables, and one for option ROM loading.

https://review.coreboot.org/c/coreboot/+/31448/10/src/device/pci_rom.c 
File src/device/pci_rom.c:

https://review.coreboot.org/c/coreboot/+/31448/10/src/device/pci_rom.c@230 
PS10, Line 230: 	if (!CONFIG(MULTIPLE_VGA_ADAPTERS)) {
> Thank you, will try to change it without using a Kconfig

This has been done already.