[coreboot-gerrit] Change in coreboot[master]: intel/fsp2_0: Make FSP_USE_REPO a SoC opt-in

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37582 )

Change subject: intel/fsp2_0: Make FSP_USE_REPO a SoC opt-in
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/cannonlake/Kc... 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/cannonlake/Kc... 
PS6, Line 68: 	select HAVE_INTEL_FSP_REPO
> Can't tell, but I would go with `if !SOC_INTEL_CANNONLAKE` since `FSP_FD_PATH` has no default value  […]

I doubt Cannon Lake works with the CFL FSP, its headers are incompatible,
IIRC, and looking at a certain Git repo, it seems one has to compile for
one or the other. (CNL seems closer to ICL than to anything in cannonlake/)

I would prefer to move the `select` to the respective platforms above.