build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43804 )
Change subject: /soc/amd/acpi Move ACPI IVRS generation to coreboot ......................................................................
Patch Set 1:
(34 comments)
https://review.coreboot.org/c/coreboot/+/43804/1/src/include/acpi/acpi_ivrs.... File src/include/acpi/acpi_ivrs.h:
https://review.coreboot.org/c/coreboot/+/43804/1/src/include/acpi/acpi_ivrs.... PS1, Line 74: #define IOMMU_FEATURE_XT_SUP 1 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/43804/1/src/include/acpi/acpi_ivrs.... PS1, Line 171: typedef struct acpi_ivrs_ivhd_40{ missing space after struct definition
https://review.coreboot.org/c/coreboot/+/43804/1/src/include/acpi/acpi_ivrs.... PS1, Line 217: uint16_t dev_id;; Statements terminations use 1 semicolon
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... File src/soc/amd/picasso/agesa_acpi.c:
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 93: static unsigned long ivhd_describe_f0_device(unsigned long current, uint16_t dev_id, uint8_t datasetting) line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 290: current = ivhd_describe_f0_device( current, PCI_DEVFN(0x13, 1), 0xf7); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 328: ivhd11_attr_ptr = (ivhd11_iommu_attr_t*) &ivrs->ivhd.iommu_feature_info; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 373: printk(BIOS_WARNING, "%s: G-series northbridge device not present!\n", __func__); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 396: capability_offset_0 = pci_read_config32(iommu_dev, ivrs->ivhd.capability_offset) ; line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 396: capability_offset_0 = pci_read_config32(iommu_dev, ivrs->ivhd.capability_offset) ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 397: capability_offset_10 = pci_read_config32(iommu_dev, ivrs->ivhd.capability_offset + 0x10) ; line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 397: capability_offset_10 = pci_read_config32(iommu_dev, ivrs->ivhd.capability_offset + 0x10) ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 398: mmio_x18_value= IOMMU_MMIO64(ivrs->ivhd.iommu_base_low + 0x18); spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 405: ivrs->ivhd.flags |= ((capability_offset_0 & CAP_OFFSET_0_IOTLB_SP) ? BIT(4) : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 413: ivrs->ivhd.iommu_info = pci_read_config16(iommu_dev, ivrs->ivhd.capability_offset + 0x10) & 0x1F; line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 414: ivrs->ivhd.iommu_info |= (pci_read_config16(iommu_dev, ivrs->ivhd.capability_offset + 0xC) &0x1F) << IOMMU_INFO_UNIT_ID_SHIFT ; line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 414: ivrs->ivhd.iommu_info |= (pci_read_config16(iommu_dev, ivrs->ivhd.capability_offset + 0xC) &0x1F) << IOMMU_INFO_UNIT_ID_SHIFT ; need consistent spacing around '&' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 414: ivrs->ivhd.iommu_info |= (pci_read_config16(iommu_dev, ivrs->ivhd.capability_offset + 0xC) &0x1F) << IOMMU_INFO_UNIT_ID_SHIFT ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 416: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_HATS) ? (mmio_x30_value & MMIO_0X30_HATS) << IOMMU_FEATURE_HATS_SHIFT : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 417: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_GATS) ? (mmio_x30_value & MMIO_0X30_GATS) << IOMMU_FEATURE_GATS_SHIFT : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 418: ivrs->ivhd.iommu_feature_info |= ((capability_offset_10 & CAP_OFFSET_0X10_MSI_NUM_PPR) ? ((capability_offset_10 & CAP_OFFSET_0X10_MSI_NUM_PPR)) >> IOMMU_FEATURE_MSI_NUM_PPR_SHIFT:0) ; line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 418: ivrs->ivhd.iommu_feature_info |= ((capability_offset_10 & CAP_OFFSET_0X10_MSI_NUM_PPR) ? ((capability_offset_10 & CAP_OFFSET_0X10_MSI_NUM_PPR)) >> IOMMU_FEATURE_MSI_NUM_PPR_SHIFT:0) ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 419: ivrs->ivhd.iommu_feature_info |= (mmio_x4000_value & MMIO_0X4000_N_COUNTER_BANKS) << IOMMU_FEATURE_PN_BANKS_SHIFT; line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 420: ivrs->ivhd.iommu_feature_info |= (mmio_x4000_value & MMIO_0X4000_N_COUNTER) << IOMMU_FEATURE_PN_COUNTERS_SHIFT; line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 421: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_PAS_MAX) ? (mmio_x30_value & MMIO_0X30_PAS_MAX) >>24 : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 421: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_PAS_MAX) ? (mmio_x30_value & MMIO_0X30_PAS_MAX) >>24 : 0); need consistent spacing around '>>' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 422: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_HE_SUP) ? IOMMU_FEATURE_HE_SUP : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 423: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_GA_SUP) ? IOMMU_FEATURE_GA_SUP : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 424: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_IA_SUP) ? IOMMU_FEATURE_IA_SUP : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 425: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_GLX_SUP) ? (mmio_x30_value & MMIO_0X30_GLX_SUP) >> 11 : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 426: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_GT_SUP) ? IOMMU_FEATURE_GT_SUP : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 427: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_NX_SUP) ? IOMMU_FEATURE_NX_SUP : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 428: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_XT_SUP) ? IOMMU_FEATURE_XT_SUP : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 431: ivrs->iv_info = pci_read_config32(iommu_dev, ivrs->ivhd.capability_offset + 0x10) & 0x007fffe0; trailing whitespace
https://review.coreboot.org/c/coreboot/+/43804/1/src/soc/amd/picasso/agesa_a... PS1, Line 431: ivrs->iv_info = pci_read_config32(iommu_dev, ivrs->ivhd.capability_offset + 0x10) & 0x007fffe0; line over 96 characters