build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31416 )
Change subject: SMBIOS: Update BIOS Information (Type 0) to version V3.2.0 ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31416/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31416/3/src/arch/x86/smbios.c@378 PS3, Line 378: if (CONFIG_ROM_SIZE >= GiB) { Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/31416/3/src/arch/x86/smbios.c@381 PS3, Line 381: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/31416/3/src/arch/x86/smbios.c@381 PS3, Line 381: } else { braces {} are not necessary for single statement blocks