[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/gspi: Check device validity before setting state

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34761 )

Change subject: soc/intel/common/gspi: Check device validity before setting state
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34761/1/src/soc/intel/common/block/... 
File src/soc/intel/common/block/gspi/gspi.c:

https://review.coreboot.org/c/coreboot/+/34761/1/src/soc/intel/common/block/... 
PS1, Line 482: 	if (device)
Actually, looking at this closer, it's probably safest to put this right after setting device (line 462):
if (!device)
   return -1;
because it looks like the rest of the function is configuring the device as though it's enabled (reset, clocks, CS); i.e. it's touching a lot of registers which may not be accessible if it hasn't been assigned resources during PCI enumeration.