Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32761 )
Change subject: soc/intel/broadwell: Use the common cpu/intel/car romstage entry
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32761/3/src/soc/intel/broadwell/romstage/rom...
File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/#/c/32761/3/src/soc/intel/broadwell/romstage/rom...
PS3, Line 67: /* Entry from cache-as-ram.inc. */
update, please
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32761
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95645271e0d93a97f544a1cc4e9a4320738e6a20
Gerrit-Change-Number: 32761
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 12 May 2019 13:14:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment