Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32651 )
Change subject: soc/amd/stoneyridge: Move GPIO support to common ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32651/2/src/mainboard/google/kahlee/mainboar... File src/mainboard/google/kahlee/mainboard.c:
https://review.coreboot.org/#/c/32651/2/src/mainboard/google/kahlee/mainboar... PS2, Line 30: <soc/smi.h> : Why is smi.h needed?
https://review.coreboot.org/#/c/32651/2/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/gpio.h:
https://review.coreboot.org/#/c/32651/2/src/soc/amd/stoneyridge/include/soc/... PS2, Line 75: Could you leave GPIO_BANK0_CONTROL, GPIO_BANK1_CONTROL and GPI2_BANK0_CONTROL in gpio.h (soc dependent)? In this way, a SOC with different MMIO offset could still use the same common block.