[coreboot-gerrit] Change in coreboot[master]: util/smc: Add and use new tool smcbiosinfo

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35484 )

Change subject: util/smc: Add and use new tool smcbiosinfo
......................................................................

Patch Set 13:

(4 comments)

https://review.coreboot.org/c/coreboot/+/35484/11/Documentation/mainboard/su... 
File Documentation/mainboard/supermicro/flashing_on_vendorbmc.md:

https://review.coreboot.org/c/coreboot/+/35484/11/Documentation/mainboard/su... 
PS11, Line 18: build
> built

Done

https://review.coreboot.org/c/coreboot/+/35484/11/Documentation/mainboard/su... 
PS11, Line 19: and
> Comma instead?

Done

https://review.coreboot.org/c/coreboot/+/35484/11/Documentation/mainboard/su... 
PS11, Line 19: and build timestamp and board config.
> Some parts fit on the line above?

Done

https://review.coreboot.org/c/coreboot/+/35484/9/util/smc/smcbiosinfo/smcbio... 
File util/smc/smcbiosinfo/smcbiosinfo.c:

https://review.coreboot.org/c/coreboot/+/35484/9/util/smc/smcbiosinfo/smcbio... 
PS9, Line 100: 			ret = 0;
> isn't printing a helpmessage doing it's job?

Done