[coreboot-gerrit] [M] Change in coreboot[main]: riscv/mb/qemu: fix DRAM probing

[ron minnich (Code Review)]

Attention is currently required from: Arthur Heymans, Arthur Heymans, Philipp Hug, ron minnich.

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36486?usp=email )

Change subject: riscv/mb/qemu: fix DRAM probing
......................................................................

Patch Set 9:

(3 comments)

File src/arch/riscv/ramdetect.c:

https://review.coreboot.org/c/coreboot/+/36486/comment/d9997f14_5282dd10 :
PS9, Line 21: #define insn_size 4
> we can't. to be really sure we'd have to read the instruction from memory. […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/36486/comment/1ee489bb_9c0ad95e :
PS9, Line 29: 	 */
> see above.

Acknowledged

https://review.coreboot.org/c/coreboot/+/36486/comment/9d0ceb5e_573ddc61 :
PS9, Line 35: 	uintptr_t addr = dram_start + (size * MiB) - sizeof(uint32_t);
> dram_start is coming from the linker file and we assume that memory is usually aligned, if not I'd r […]

Acknowledged