[coreboot-gerrit] Patch set updated for coreboot: c571ebe coreboot: don't return struct lb_memory * from write_tables()

[Aaron Durbin]

Aaron Durbin ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5301

-gerrit

commit c571ebe87587f7aefd67d5bf344e7296d52f0385
Author: Aaron Durbin 
Date:   Tue Feb 18 19:36:05 2014 -0600

coreboot: don't return struct lb_memory * from write_tables()

No one is interrogating the write_tables() return value. Therefore,
    drop it.

Change-Id: I97e707f071942239c9a0fa0914af3679ee7a9c3c
    Signed-off-by: Aaron Durbin 
---
 src/arch/armv7/tables.c    | 6 ++----
 src/arch/x86/boot/tables.c | 4 +---
 src/include/boot/tables.h  | 2 +-
 3 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/arch/armv7/tables.c b/src/arch/armv7/tables.c
index 7e7cbe4..20c5a9f 100644
--- a/src/arch/armv7/tables.c
+++ b/src/arch/armv7/tables.c
@@ -46,7 +46,7 @@ void cbmem_fail_resume(void)
 {
 }

-struct lb_memory *write_tables(void)
+void write_tables(void)
 {
    unsigned long table_pointer, new_table_pointer;

@@ -56,7 +56,7 @@ struct lb_memory *write_tables(void)
    					MAX_COREBOOT_TABLE_SIZE);
    if (!table_pointer) {
    	printk(BIOS_ERR, "Could not add CBMEM for coreboot table.\n");
-		return NULL;
+		return;
    }

new_table_pointer = write_coreboot_table(0UL, 0UL,
@@ -74,6 +74,4 @@ struct lb_memory *write_tables(void)

/* Print CBMEM sections */
    cbmem_list();
-
-	return get_lb_mem();
 }
diff --git a/src/arch/x86/boot/tables.c b/src/arch/x86/boot/tables.c
index e980ed8..42e431e 100644
--- a/src/arch/x86/boot/tables.c
+++ b/src/arch/x86/boot/tables.c
@@ -38,7 +38,7 @@ void cbmem_arch_init(void)
    move_gdt();
 }

-struct lb_memory *write_tables(void)
+void write_tables(void)
 {
    unsigned long low_table_start, low_table_end;
    unsigned long rom_table_start, rom_table_end;
@@ -244,6 +244,4 @@ struct lb_memory *write_tables(void)

/* Print CBMEM sections */
    cbmem_list();
-
-	return get_lb_mem();
 }
diff --git a/src/include/boot/tables.h b/src/include/boot/tables.h
index f9e91a4..e86adfc 100644
--- a/src/include/boot/tables.h
+++ b/src/include/boot/tables.h
@@ -3,6 +3,6 @@

#include <boot/coreboot_tables.h>

-struct lb_memory *write_tables(void);
+void write_tables(void);

#endif /* BOOT_TABLES_H */