Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40796 )
Change subject: mainboard/google/kahlee: move specific setting to variant
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40796/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40796/2//COMMIT_MSG@10
PS2, Line 10:
Maybe mention that this file is currently only used for careena, so after moving everything to the c […]
Done
https://review.coreboot.org/c/coreboot/+/40796/2//COMMIT_MSG@11
PS2, Line 11: 154357210
b:154848243 - this is the power sequence specific bug
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I658526e44aadc47bdc5538f506a1bfe2e5f20f63
Gerrit-Change-Number: 40796
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 29 Apr 2020 03:16:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment