Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31173 )
Change subject: google/mistral: Support triggering Recovery/FDR.
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/31173/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31173/5//COMMIT_MSG@7
PS5, Line 7: google/mistral: Support triggering Recovery/FDR.
Please remove the dot at the end.
https://review.coreboot.org/#/c/31173/5//COMMIT_MSG@10
PS5, Line 10: switch(GPIO77)
Please add a space before the (.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdbd696ee3fd9f073cc44a49ad341cad7e33845e
Gerrit-Change-Number: 31173
Gerrit-PatchSet: 5
Gerrit-Owner: SANTHOSH JANARDHANA HASSAN
sahassan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN
sahassan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 Feb 2019 12:40:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment