[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd: Create AMD common reset code

[Felix Held (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger, Elyes Haouas.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72658 )

Change subject: soc/amd: Create AMD common reset code
......................................................................

Patch Set 2: Code-Review+2

(3 comments)

File src/soc/amd/common/block/include/amdblocks/reset.h:

https://review.coreboot.org/c/coreboot/+/72658/comment/411f348b_40d9d1df 
PS1, Line 10: #include <soc/southbridge.h>
            : 
            : 
            : void do_warm_reset(void);
> Thanks, that was a mistake.

Done

File src/soc/amd/common/block/reset/reset.c:

PS1:
> There's a lot of stuff that resides in various register blocks just because that's where they put it […]

Done

https://review.coreboot.org/c/coreboot/+/72658/comment/272eb00b_ff63613f 
PS1, Line 22: 	outb(RST_CPU | SYS_RST, RST_CNT);
> How about just adding a comment that do_cold_reset() doesn't return? I can't say I really like eithe […]

that works for me too