Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46312 )
Change subject: soc/intel/common: Boot time optimization
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46312/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/46312/3/src/soc/intel/common/block/...
PS3, Line 630: int
bool ?
Done
https://review.coreboot.org/c/coreboot/+/46312/3/src/soc/intel/common/block/...
PS3, Line 646: uint8_t
bool ?
Done
https://review.coreboot.org/c/coreboot/+/46312/3/src/soc/intel/common/block/...
PS3, Line 793: uint8_t
Perhaps add "CSE_LITE_SKU_NO_ERROR = 0" to the enum csme_failure_reason and then have this routine d […]
Yes, it make sense to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46312
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If043c9cb99fb822b62633591bf9c5bd75dfe8349
Gerrit-Change-Number: 46312
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 14 Oct 2020 21:01:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment