Attention is currently required from: Michał Żygowski. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63656 )
Change subject: mb/msi/ms7d25: Configure PCIe Root Ports ......................................................................
Patch Set 9: Verified-1
(57 comments)
File src/mainboard/msi/ms7d25/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/2db41601_7f784b30 PS9, Line 142: _PAD_CFG_STRUCT(VGPIO_4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/beee8641_f6ed064d PS9, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/a5be5c04_5bc90dc9 PS9, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_0 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/daf7c377_34808ba8 PS9, Line 173: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/f6bf29a3_16825731 PS9, Line 173: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_1 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/a09b3af6_d3254468 PS9, Line 174: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/5289ba14_e970c5c9 PS9, Line 174: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_2 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/0187050c_f29ddb46 PS9, Line 175: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/89fc2401_c6f312e8 PS9, Line 175: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_3 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/caa57988_319bf318 PS9, Line 176: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_8 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/22943b27_0612cd94 PS9, Line 176: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_8 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/d0a265db_16ee5cfb PS9, Line 177: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_9 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/67894693_9c9b057c PS9, Line 177: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_9 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/d8ad8538_f01b9919 PS9, Line 178: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_10 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/8e9a4e9f_33c00c20 PS9, Line 178: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_10 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/b7e62a80_20d2d561 PS9, Line 179: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_11 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/54d3f543_908ee8b7 PS9, Line 179: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_11 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/81961808_fb88fdc8 PS9, Line 425: // _PAD_CFG_STRUCT(VGPIO_PCIE_0, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/9351c93b_c48528df PS9, Line 426: // _PAD_CFG_STRUCT(VGPIO_PCIE_1, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/89a39e58_eba8e620 PS9, Line 427: // _PAD_CFG_STRUCT(VGPIO_PCIE_2, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/6a4a87f3_6c329a4a PS9, Line 428: // _PAD_CFG_STRUCT(VGPIO_PCIE_3, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/a2355ee6_f12d6194 PS9, Line 429: // _PAD_CFG_STRUCT(VGPIO_PCIE_4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/4f84e1c9_1c03a950 PS9, Line 430: // _PAD_CFG_STRUCT(VGPIO_PCIE_5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/addc6b93_8c3f193f PS9, Line 431: // _PAD_CFG_STRUCT(VGPIO_PCIE_6, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/211b07d8_4b95cfe0 PS9, Line 432: // _PAD_CFG_STRUCT(VGPIO_PCIE_7, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/112ee283_91f619be PS9, Line 433: // _PAD_CFG_STRUCT(VGPIO_PCIE_8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/485d62f5_58c5248c PS9, Line 434: // _PAD_CFG_STRUCT(VGPIO_PCIE_9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/854f5034_fa62ab90 PS9, Line 435: // _PAD_CFG_STRUCT(VGPIO_PCIE_10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/45192d85_19dc8a82 PS9, Line 436: // _PAD_CFG_STRUCT(VGPIO_PCIE_11, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/bcfa29e9_230228c8 PS9, Line 437: // _PAD_CFG_STRUCT(VGPIO_PCIE_12, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/b6388272_1488e170 PS9, Line 438: // _PAD_CFG_STRUCT(VGPIO_PCIE_13, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/189b3f61_0505b2a9 PS9, Line 439: // _PAD_CFG_STRUCT(VGPIO_PCIE_14, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/bf6f4d70_e97a9433 PS9, Line 440: // _PAD_CFG_STRUCT(VGPIO_PCIE_15, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/f0b78392_9f6a657c PS9, Line 441: // _PAD_CFG_STRUCT(VGPIO_PCIE_64, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/c1711c58_abecbae0 PS9, Line 442: // _PAD_CFG_STRUCT(VGPIO_PCIE_65, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/44abbf05_893302bf PS9, Line 443: // _PAD_CFG_STRUCT(VGPIO_PCIE_66, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/2ced38b8_be5fd056 PS9, Line 444: // _PAD_CFG_STRUCT(VGPIO_PCIE_67, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/98252752_3b39d204 PS9, Line 447: // _PAD_CFG_STRUCT(VGPIO_PCIE_16, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/9e07034e_dacad8d3 PS9, Line 448: // _PAD_CFG_STRUCT(VGPIO_PCIE_17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/8d539257_f76e6e78 PS9, Line 449: // _PAD_CFG_STRUCT(VGPIO_PCIE_18, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/5bf235f7_6fe692fd PS9, Line 450: // _PAD_CFG_STRUCT(VGPIO_PCIE_19, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/f6ab407c_1730550b PS9, Line 451: // _PAD_CFG_STRUCT(VGPIO_PCIE_20, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/8f48fc9a_8debeba6 PS9, Line 452: // _PAD_CFG_STRUCT(VGPIO_PCIE_21, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/eebe3457_533b2a75 PS9, Line 453: // _PAD_CFG_STRUCT(VGPIO_PCIE_22, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/f1ea16e5_fe0186b2 PS9, Line 454: // _PAD_CFG_STRUCT(VGPIO_PCIE_23, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/ed430990_a29d0390 PS9, Line 455: // _PAD_CFG_STRUCT(VGPIO_PCIE_24, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/97b2d267_d639131b PS9, Line 456: // _PAD_CFG_STRUCT(VGPIO_PCIE_25, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/eeddb689_6fd03319 PS9, Line 457: // _PAD_CFG_STRUCT(VGPIO_PCIE_26, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/e54900c1_5e441e34 PS9, Line 458: // _PAD_CFG_STRUCT(VGPIO_PCIE_27, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/6533b78d_c1983e74 PS9, Line 459: // _PAD_CFG_STRUCT(VGPIO_PCIE_28, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/a59f0043_80e3b1ec PS9, Line 460: // _PAD_CFG_STRUCT(VGPIO_PCIE_29, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/dd320321_cc980410 PS9, Line 461: // _PAD_CFG_STRUCT(VGPIO_PCIE_30, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/25c9365c_5712ca0a PS9, Line 462: // _PAD_CFG_STRUCT(VGPIO_PCIE_31, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/b0c71da4_c3927cd7 PS9, Line 463: // _PAD_CFG_STRUCT(VGPIO_PCIE_68, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/49e2f5b4_e85cfbc8 PS9, Line 464: // _PAD_CFG_STRUCT(VGPIO_PCIE_69, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/ec8bb31f_bdefbdd1 PS9, Line 465: // _PAD_CFG_STRUCT(VGPIO_PCIE_70, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150204): https://review.coreboot.org/c/coreboot/+/63656/comment/0a0956f0_312e5b7a PS9, Line 466: // _PAD_CFG_STRUCT(VGPIO_PCIE_71, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters