EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )
Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level ......................................................................
Patch Set 13:
Patch Set 13:
Patch Set 13:
Patch Set 13:
Patch Set 13:
Patch Set 13:
Patch Set 13:
@Subrata, I found the issue here. APL use the common platform.asl but not use the common globalnvs.asl that cause this issue. How can we fix this?
looks like its common vs specific SOC changes issue
now we have 2 option
Do you really need to save and restore GPIO PM setting in _PTS and _WAK, because _PTS/_WAK will only call for S5/S3 case where anyway your bootblock changes are in place to fix GPIO PM issue, isn't its duplicate ? i guess you have to only bother about MPTS/MWAK ?
Like SKL has its own platform.asl rather using common one. Its not feasible to make GPIO PM override feature flag for APL where this feature doesn't exist.
I think the bootblock is called when resume not when suspend. _WAK is not needed, but _PTS still needed.
@Eric, i didn't get this, if _WAK is not required when why you think _PTS is required ? Can you please let me know what you want achieve using _PTS ? May be i'm missing something here :(
We want enable PM before suspend, this is why we need _PTS.
Any idea why we might want to do this? i mean what would be the benefit because during resume bootblock code will override based on .cb config.
I think we don't have S3 handler in the coreboot.
can you please take a look into this https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...
we can create a soc callback from this common code to soc if required for S3 and S5 case. These are S3/S5 handler for coreboot.
I knew this, but we don't use it. We can discuss with google about this. Since @Tim added this. S3 always be a back up for s0ix. And IMO, we rarely use it expect for validation. So you mean I just remove this for PTS and WAK? Or you will add a flag like I suggested. I am fine with any.