Attention is currently required from: Anil Kumar K, Jamie Ryu, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79413?usp=email )
Change subject: soc/intel/common/block/cse: Use IFWI build version for update check
......................................................................
Patch Set 16: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79413/comment/1138a00c_2e11cfab :
PS15, Line 7: verion
typo
Done
https://review.coreboot.org/c/coreboot/+/79413/comment/5c546a91_8d30a6ea :
PS15, Line 9:
space not required
Done
https://review.coreboot.org/c/coreboot/+/79413/comment/bf4a737b_6d78c874 :
PS15, Line 9: cse bpdt
use CAPS
Done
https://review.coreboot.org/c/coreboot/+/79413/comment/e32ed779_c5ad8d1e :
PS15, Line 17: FWs
pls provide ex: on which other FW is being referred to here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79413?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib95ffeabda01c66fcce35ca3065c06362c75d848
Gerrit-Change-Number: 79413
Gerrit-PatchSet: 16
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Wed, 28 Feb 2024 04:32:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-MessageType: comment