[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )

Change subject: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33738/10/src/soc/intel/icelake/Kcon... 
File src/soc/intel/icelake/Kconfig:

https://review.coreboot.org/c/coreboot/+/33738/10/src/soc/intel/icelake/Kcon... 
PS10, Line 24: 	select HAVE_FSP_GOP if !ENABLE_DISPLAY_OVER_EXT_PCIE_GFX
> But, running graphics init on a different device than IGD doesn't make the GOP driver in FSP disappear. It's still there.

yes, that's true but based on RUN_FSP_GOP select, we will fill vbt pointer

if (!CONFIG(RUN_FSP_GOP))
                return NULL;

and inside FSP logic, we will again check if vbt point is NULL or not, if vbt pointer is not NULL, then only we execute GFX PEIM.efi module else not.