Attention is currently required from: Duncan Laurie, John Zhao, Tim Wawrzynczak, Brandon Breitenstein.
Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48630 )
Change subject: drivers/intel/usb4: Enable retimer FW upgrade mux interaction
......................................................................
Patch Set 14:
(1 comment)
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/48630/comment/45674899_9ee32606
PS13, Line 109: const char *RFWU = mainboard_retimer_fw_update_path();
:
: /*
: * Get information to set retimer info from Arg3[0]
: * Local0 = DeRefOf (Arg3[0])
: */
: acpigen_get_package_op_element(ARG3_OP, 0, LOCAL0_OP);
:
: /*
: * Write the EC RAM for Retimer Upgrade
: * RFWU = LOCAL0
: */
: acpigen_write_store();
: acpigen_emit_byte(LOCAL0_OP);
: acpigen_emit_namestring(RFWU);
:
: /* Return (Zero) */
: acpigen_write_return_integer(0);
Sorry I just meant move the coreboot code here that is generating the ACPI code to ec/google/chromee […]
Great. Thanks Duncan.
I thought you meant the code to be moved into EC firmware itself.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I768cfb56790049c231173b0ea0f8e08fe6b64b93
Gerrit-Change-Number: 48630
Gerrit-PatchSet: 14
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Comment-Date: Wed, 13 Jan 2021 19:38:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-MessageType: comment