Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38678 )
Change subject: soc/intel/tigerlake: Update Kconfig related to JSL
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38678/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38678/2//COMMIT_MSG@10
PS2, Line 10: 1. select INTEL_CAR_NEM for SOC_INTEL_JASPERLAKE
no Nico, we are seeing some issue with NEM enhanced mode like other SoC we support. […]
As I understand it, we support another mode beside NEM (enhanced) for APL.
In common/block/cpu/Kconfig we have:
* config INTEL_CAR_NEM
* config INTEL_CAR_CQOS
* config INTEL_CAR_NEM_ENHANCED.
It's the CQOS option that I was referring to.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aa52c80bfd6134164a0925ea548579b3cc54a55
Gerrit-Change-Number: 38678
Gerrit-PatchSet: 2
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 05 Feb 2020 12:13:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment