Attention is currently required from: Kyösti Mälkki.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74604 )
Change subject: [WIP] mb/google: Re-arrange mainboard_smi_sleep()
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/auron/smihandler.c:
https://review.coreboot.org/c/coreboot/+/74604/comment/8304e290_24a51827
PS1, Line 47: case ACPI_S4:
are we sure these board properly support S4?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a10afa2b816dc8c01074be68a63114ee027c1e2
Gerrit-Change-Number: 74604
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 27 Apr 2023 16:25:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment