Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36836 )
Change subject: Make firmware update hardware version aware ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/em100/+/36836/1/firmware.c File firmware.c:
https://review.coreboot.org/c/em100/+/36836/1/firmware.c@203 PS1, Line 203: 4 should we name them? or only once there are three of them?
https://review.coreboot.org/c/em100/+/36836/1/firmware.c@243 PS1, Line 243: em100->hwversion == 4 It's still potentially an EM100Pro firmware file, so the error message would be confusing, no? I'd also put the hwversion test separately and before the content snooping to prepare for future changes when there are updates.