[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/i945: Use macro instead of magic number

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30993 )

Change subject: nb/intel/i945: Use macro instead of magic number
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/30993/2/src/northbridge/intel/i945/early_ini... 
File src/northbridge/intel/i945/early_init.c:

https://review.coreboot.org/#/c/30993/2/src/northbridge/intel/i945/early_ini... 
PS2, Line 350: RCBA32(RP1D) = 0x01000003
[23:16] is R/WO .
this write is not needed and it will prevent as to write 
RCBA32(RP1D) |= (2 << 16); (line 377)

https://review.coreboot.org/#/c/30993/2/src/northbridge/intel/i945/early_ini... 
PS2, Line 351: RCBA32(RP2D) = 0x02000002;
             : 	RCBA32(RP3D) = 0x03000002;
             : 	RCBA32(RP4D) = 0x04000002;
             : 	RCBA32(HDD) = 0x0f000003;
             : 	RCBA32(RP5D) = 0x05000002;
same ...