6 Nov
2020
6 Nov
'20
5:20 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )
Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 22: int *curr_index
No, because the chip driver can be used by multiple devices. […]
True, this is just ugly... I guess you could use a file-level static and reset it on calls to fill_ssdt, but that isn't much better
--
To view, visit https://review.coreboot.org/c/coreboot/+/46961
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d
Gerrit-Change-Number: 46961
Gerrit-PatchSet: 5
Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 06 Nov 2020 17:20:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment