Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/...
File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/...
PS3, Line 20: /* coreboot specific header */
why remove this comment?
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/...
PS3, Line 35: : 0x10ec0283
and this one? it helps a reader understand the verb contents
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a3bffcb0fa0de35480a767a1e3aa323e0591198
Gerrit-Change-Number: 37840
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Dec 2019 19:39:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment