Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57349 )
Change subject: utils/abuild: select FSP_USE_REPO instead of ADD_FSP_BINARIES
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
So, if I understand this right, it only worked because for platforms […]
yes, that was why adding paths of not existing fsp binaries made the jenkins build break. already ran into this when working on picasso, but didn't have the time to investigate that back then
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57349
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72faa6f9e5f2b06ab7cd43595ae0b49bf4d39630
Gerrit-Change-Number: 57349
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sun, 05 Sep 2021 17:44:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment