build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34449 )
Change subject: soc/intel/common: Set controller state to active in GSPI init ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34449/1/src/soc/intel/common/block/... File src/soc/intel/common/block/gspi/gspi.c:
https://review.coreboot.org/c/coreboot/+/34449/1/src/soc/intel/common/block/... PS1, Line 179: lpss_set_power_state(tree_dev, STATE_D0); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34449/1/src/soc/intel/common/block/... PS1, Line 179: lpss_set_power_state(tree_dev, STATE_D0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34449/1/src/soc/intel/common/block/... PS1, Line 458: lpss_set_power_state((struct device*) dev, STATE_D0); "(foo*)" should be "(foo *)"