Attention is currently required from: Andrey Petrov, Arthur Heymans, Christian Walter, Kapil Porwal, Lean Sheng Tan, Nill Ge, Reka Norman, Shuo Liu, Subrata Banik, TangYiwei, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77557?usp=email )
Change subject: soc/intel/xeon_sp: Use MRC_STASH_TO_CBMEM config
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
I based on the same upstream tip and pick your latest 2 changes: […]
I pick all 4 cls:
77594/2, 77557/3, 77556/5, 77295/11 but doesn't work. because CB:77556 save_memory_training_data() is only being run after FSP-M and not after FSP-S, for our case there is no FSP_NON_VOLATILE_STORAGE_HOB can be stashed.
at romstage:
[SPEW ] Calling FspMemoryInit: 0xff058f30
..
[ERROR] FSP_NON_VOLATILE_STORAGE_HOB missing!
[SPEW ] FspMemoryInit returned 0x00000000
at ramstage:
[DEBUG] BS: BS_DEV_ENUMERATE run times (exec / console): 1367 / 5984 ms
[DEBUG] FMAP: area RW_MRC_CACHE found @ 3000000 (65536 bytes)
[INFO ] MRC: No data in cbmem for 'RW_MRC_CACHE'.
Do I need to select MRC_WRITE_NV_LATE or anything?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77557?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6275fbc0546468f36baee73691a285092e857e0a
Gerrit-Change-Number: 77557
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 01 Sep 2023 08:48:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-MessageType: comment