[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Move some SMI utility functions

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42988 )

Change subject: soc/amd/picasso: Move some SMI utility functions
......................................................................

Patch Set 3:

i like where this patch is heading. was planning to do a soc/amd wide sci/smi/gpio cleanup and also move the smi/sci setup function from the common gpio.c file to another file that only gets built into ramstage and replace the check if we're not in verstage on psp with a check if we're in ramstage; if we're not in ramstage and the smi/sci flags are set than print a warning. this will also allow to link the the soc's gpio.c file only in ramstage. i'll probably just push a few gpio fixes this week and look into the refactoring more when cezanne gets through romstage or maybe ramstage to unblock the rest of the team