Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49100 )
Change subject: mb/intel/adlrvp: Fix FW download failed for PEG 060, 010
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49100/comment/edcaf22e_6416485c
PS5, Line 262: device pci 1c.2 off end # RP3
Please help turn on this as well. My patch is based on device tree to set the enable bit..
Eric, ideally we don't have any device in PCH RP3 and 4 its due to bug in FSP, we had to enable those UPDs. do you still want to enable this ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49100
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cd8cba02a96185803a0c0d442f3d6aa495d2642
Gerrit-Change-Number: 49100
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 09 Jan 2021 11:46:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment