[coreboot-gerrit] Change in coreboot[master]: sb/amd/pi/hudson/acpi/fch.asl: Convert to ASL 2.0 syntax

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45862 )

Change subject: sb/amd/pi/hudson/acpi/fch.asl: Convert to ASL 2.0 syntax
......................................................................

sb/amd/pi/hudson/acpi/fch.asl: Convert to ASL 2.0 syntax

Change-Id: Ie413f36ef11a42a23d7d265d7a66f5e0d088892e
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45862
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
Reviewed-by: Angel Pons 
---
M src/southbridge/amd/pi/hudson/acpi/fch.asl
1 file changed, 15 insertions(+), 15 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/southbridge/amd/pi/hudson/acpi/fch.asl b/src/southbridge/amd/pi/hudson/acpi/fch.asl
index 53095e0..25b53d3 100644
--- a/src/southbridge/amd/pi/hudson/acpi/fch.asl
+++ b/src/southbridge/amd/pi/hudson/acpi/fch.asl
@@ -7,14 +7,14 @@
 Method(_OSC,4)
 {
    /* Check for proper PCI/PCIe UUID */
-	If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))
+	If (Arg0 == ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))
    {
    	/* Let OS control everything */
    	Return (Arg3)
    } Else {
    	CreateDWordField(Arg3,0,CDW1)
-		Or(CDW1,4,CDW1)	// Unrecognized UUID
-		Return(Arg3)
+		CDW1 |= 4	// Unrecognized UUID
+		Return (Arg3)
    }
 }

@@ -107,12 +107,12 @@
     * 32bit (0x00000000 - TOM1) will wrap and give the same
     * result as 64bit (0x100000000 - TOM1).
     */
-	Store(TOM1, MM1B)
-	ShiftLeft(0x10000000, 4, Local0)
-	Subtract(Local0, TOM1, Local0)
-	Store(Local0, MM1L)
+	MM1B = TOM1
+	Local0 = 0x10000000 << 4
+	Local0 -= TOM1
+	MM1L = Local0

-	Return(CRES) /* note to change the Name buffer */
+	Return (CRES) /* note to change the Name buffer */
 } /* end of Method(_SB.PCI0._CRS) */

#if CONFIG(HUDSON_IMC_FWM)
@@ -156,21 +156,21 @@

Method(OSFL, 0){

-	if (LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
+	if (OSVR != Ones) {Return (OSVR)}	/* OS version was already detected */

if (CondRefOf(_OSI))
    {
-		Store(1, OSVR)					/* Assume some form of XP */
+		OSVR = 1				/* Assume some form of XP */
    	if (_OSI("Windows 2006"))		/* Vista */
    	{
-			Store(2, OSVR)
+			OSVR = 2
    	}
    } else {
-		If(WCMP(_OS,"Linux")) {
-			Store(3, OSVR)				/* Linux */
+		If (WCMP(_OS,"Linux")) {
+			OSVR = 3			/* Linux */
    	} Else {
-			Store(4, OSVR)				/* Gotta be WinCE */
+			OSVR = 4			/* Gotta be WinCE */
    	}
    }
-	Return(OSVR)
+	Return (OSVR)
 }