Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56650 )
Change subject: soc/intel/common: Don't suppress SPD Module Type value ......................................................................
soc/intel/common: Don't suppress SPD Module Type value
This patch fixes an issue where SPD original module type is getting suppressed due to DDR2 module type conversion. Make use of default case to pass the original SPD module type without overriding to `undefined` SPD memory type as part of DDR2 module type conversion.
Change-Id: Ia3f38c24efa6a8685639bb607926e2fd9c702ff6 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/smbios.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/56650/1
diff --git a/src/soc/intel/common/smbios.c b/src/soc/intel/common/smbios.c index 9cbdecb..58b6e3c 100644 --- a/src/soc/intel/common/smbios.c +++ b/src/soc/intel/common/smbios.c @@ -33,9 +33,11 @@ dimm->mod_type = SPD_RDIMM; break; case SPD_DDR3_DIMM_TYPE_UNDEFINED: - default: dimm->mod_type = SPD_UNDEFINED; break; + default: + dimm->mod_type = mod_type; + break; } dimm->dimm_size = dimm_capacity; dimm->ddr_type = ddr_type;