HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39614 )
Change subject: sc7180: Add display dsi interface programming. ......................................................................
Patch Set 23:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39614/23/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/39614/23/src/soc/qualcomm/sc7180/di... PS23, Line 5: nclude <delay.h> please, is it used ?
https://review.coreboot.org/c/coreboot/+/39614/23/src/soc/qualcomm/sc7180/di... PS23, Line 6: #include <edid.h> missing <types.h>
https://review.coreboot.org/c/coreboot/+/39614/23/src/soc/qualcomm/sc7180/di... PS23, Line 83: void mdss_dsi_video_mode_config(struct edid *edid, : uint32_t bpp) in one line ?