[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Do not unhide P2SB before disabling HECI

[Angel Pons (Code Review)]

Attention is currently required from: Nico Huber, Benjamin Doron, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51205 )

Change subject: soc/intel/skylake: Do not unhide P2SB before disabling HECI
......................................................................

Patch Set 3: Code-Review-1

(1 comment)

File src/soc/intel/skylake/finalize.c:

https://review.coreboot.org/c/coreboot/+/51205/comment/29026c48_81ccdd47 
PS3, Line 37: 	p2sb_unhide();
> We unconditionally hide P2SB at the end of `pch_finalize_script`, but may conditionally unhide it fi […]

Removing this call doesn't make things clearer, IMHO. It only introduces potential problems in case P2SB gets hidden in specific cases.