[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Provide mmc.c for setting dll registers.

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )

Change subject: soc/intel/common/block: Provide mmc.c for setting dll registers.
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35040/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/scs/mmc.c:

https://review.coreboot.org/c/coreboot/+/35040/5/src/soc/intel/common/block/... 
PS5, Line 61: SOC_INTEL_COMMON_MMC_OVERRIDE
> Okay. Can you please update the Kconfig help text to clearly indicate when it should be used.

ok, will do it.
thank you

https://review.coreboot.org/c/coreboot/+/35040/8/src/soc/intel/common/block/... 
File src/soc/intel/common/block/scs/mmc.c:

https://review.coreboot.org/c/coreboot/+/35040/8/src/soc/intel/common/block/... 
PS8, Line 67: if (override) {
            : 		printk(BIOS_INFO, "Skip Emmc dll value programming\n");
            : 		return -1;
            : 	}
            :
> Oh okay. what about my suggestion about having another helper function: write_mmc_dll_param […]

will do it
thank you