Attention is currently required from: Ravi kumar, Paul Menzel.
Roja Rani Yarubandi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47075 )
Change subject: sc7280: Add SPI-NOR support
......................................................................
Patch Set 12:
(3 comments)
Patchset:
PS12:
Does all this need to be duplicated, or is there common code?
Changes are taken from sc7180.
File src/soc/qualcomm/sc7280/Kconfig:
https://review.coreboot.org/c/coreboot/+/47075/comment/9b921011_ea348562
PS12, Line 33: Build Flash Using SPI-NOR
Can you please rephrase? Do you mean an *image*?
ok..will rephrase
File src/soc/qualcomm/sc7280/qspi.c:
https://review.coreboot.org/c/coreboot/+/47075/comment/f9776337_dbc512ab
PS12, Line 75: }
Please add a timer to abort after 50 ms or so.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d4159939a57648c54dcb06aea3645f1dfe10903
Gerrit-Change-Number: 47075
Gerrit-PatchSet: 12
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi
c_rojay@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 05 Mar 2021 05:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment