John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32432 )
Change subject: soc/intel/cnl: Enable VT-d ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/#/c/32432/8/src/soc/intel/cannonlake/acpi.c File src/soc/intel/cannonlake/acpi.c:
https://review.coreboot.org/#/c/32432/8/src/soc/intel/cannonlake/acpi.c@345 PS8, Line 345: acpi_dmar_rmrr_fixup(tmp, current);
Please mention this fix in the commit message.
done
https://review.coreboot.org/#/c/32432/8/src/soc/intel/common/Kconfig File src/soc/intel/common/Kconfig:
https://review.coreboot.org/#/c/32432/8/src/soc/intel/common/Kconfig@65 PS8, Line 65: config SOC_INTEL_COMMON_VTD
This does nothing so far. Drop it until somebody needs an option to disable […]
It appears build failures if simply removing SOC_INTEL_COMMON_VTD here as soc/intel/cannonlake/Kconfig still refers to it.
"Error: Undefined Symbol 'SOC_INTEL_COMMON_VTD' used at src/soc/intel/cannonlake/Kconfig."
I am considering no update.