Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Paul Menzel, Martin Roth, Karthik Ramasubramanian, Felix Held.
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71562 )
Change subject: soc/amd/mendocino: Hook up UPD dxio_tx_vboost_enable for PCIe optimization
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71562/comment/32a74de6_c74150dc
PS2, Line 7: soc/amd/mendocino: add dxio_tx_vboost_enable for pcie optimization
Reading this, I thought it’s getting enabled. Maybe: […]
Thanks.
File src/soc/amd/mendocino/chip.h:
https://review.coreboot.org/c/coreboot/+/71562/comment/38c92534_764c1ef6
PS2, Line 167: need to check PCIe signal integrity before enabling.
- Please start sentences with capital letter. […]
How can the integrity be checked?
it's a industry standard signal integrity testing for PCIe.
https://review.coreboot.org/c/coreboot/+/71562/comment/f95dde1a_20d7c753
PS2, Line 167: set
Set
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71562
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05ae5b3091219e0cb1fe469c929fad6a725db678
Gerrit-Change-Number: 71562
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 03 Jan 2023 18:58:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment