Keith Short has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32365 )
Change subject: coreboot: Run mainboard specific code before Cr50 reset ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/32365/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32365/1//COMMIT_MSG@18 PS1, Line 18: Unexpected Cr50 TPM mode 3
Isn't TPM mode 3 actually an error: https://chromium.googlesource. […]
When the Cr50 key ladder is disabled, the Cr50 returns VENDOR_RC_INTERNAL_ERROR and does not return the current TPM mode in the TPM response. tlcl_cr50_get_tpm_mode() sets the tpm_mode output parameter to TPM_MODE_INVALID in this path. I'll update the commit message to note that this was only a false error when the key ladder is disabled.
https://review.coreboot.org/#/c/32365/1/src/vendorcode/google/chromeos/cr50_... File src/vendorcode/google/chromeos/cr50_enable_update.c:
https://review.coreboot.org/#/c/32365/1/src/vendorcode/google/chromeos/cr50_... PS1, Line 36: cr50_reset_if_needed
Can we split this function into two? […]
Done, but I skipped creating the cr50_reset_now() helper function and call tlcl_cr50_immediate_reset() directly from enable_update().
https://review.coreboot.org/#/c/32365/1/src/vendorcode/google/chromeos/cr50_... PS1, Line 147: cr50_reset_if_needed(C50_RESET_DELAY_MS)
This can be then changed to: […]
Done
https://review.coreboot.org/#/c/32365/1/src/vendorcode/google/chromeos/cr50_... PS1, Line 163:
and you can add the reset here: […]
Done