Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11330
-gerrit
commit 70c768ccd38e7629074e6c2b633a63c8a7bbcbff Author: Patrick Georgi patrick@georgi-clan.de Date: Tue Aug 25 20:17:14 2015 +0200
cbfstool: passing a header is now mandatory for converters
Change-Id: Iea5377af735b06bcaefb999547a8896b1c70763a Signed-off-by: Patrick Georgi patrick@georgi-clan.de --- util/cbfstool/cbfstool.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index 465580c..0939a06 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -247,8 +247,7 @@ static int cbfstool_convert_mkstage(struct buffer *buffer, uint32_t *offset, buffer_delete(buffer); // direct assign, no dupe. memcpy(buffer, &output, sizeof(*buffer)); - if (header) - header->len = htonl(output.size); + header->len = htonl(output.size); return 0; }
@@ -279,8 +278,7 @@ static int cbfstool_convert_mkpayload(struct buffer *buffer, buffer_delete(buffer); // direct assign, no dupe. memcpy(buffer, &output, sizeof(*buffer)); - if (header) - header->len = htonl(output.size); + header->len = htonl(output.size); return 0; }
@@ -297,8 +295,7 @@ static int cbfstool_convert_mkflatpayload(struct buffer *buffer, buffer_delete(buffer); // direct assign, no dupe. memcpy(buffer, &output, sizeof(*buffer)); - if (header) - header->len = htonl(output.size); + header->len = htonl(output.size); return 0; }