[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell/smbus.c: Add support for i2c mode block write

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33225 )

Change subject: soc/intel/braswell/smbus.c: Add support for i2c mode block write
......................................................................

Patch Set 9:

There is also the Linux smbus driver which doesn't know any
quirks, it seems. It uses SMBHSTCMD for the first byte for
I2C block writes with I2C_EN, and SMBHSTDAT1 for the I2C_
BLOCK_READ command without I2C_EN. So basically just as
documented. But it's hard to tell if that code is tested
(on all platforms?).

I have APL/SKL/CFL boards here with an 24LC256, so I should
be able to write some test patterns. Then we could also say
if these platforms behave as documented.