Attention is currently required from: Felix Singer, Arthur Heymans.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67076 )
Change subject: soc/intel/apollolake: Communicate with the PMC over Trusted Sideband
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/apollolake/acpi/pmc_ipc.asl:
https://review.coreboot.org/c/coreboot/+/67076/comment/b12f2232_a1db898c
PS7, Line 44: Or (ShiftLeft (And (Arg0, 0xff), 0), Local0, Local0) /* 7:0 Command ID */
The shift operation is left, but otherwise it looks good […]
Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide33c2deca4c254a18e4878d22e8f1279b39428e
Gerrit-Change-Number: 67076
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 13 Apr 2023 20:11:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Gerrit-MessageType: comment