[coreboot-gerrit] Change in coreboot[master]: include/device/pci_ids: add PCI IDs for new AMD SoCs

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47703 )

Change subject: include/device/pci_ids: add PCI IDs for new AMD SoCs
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47703/3/src/include/device/pci_ids.... 
File src/include/device/pci_ids.h:

https://review.coreboot.org/c/coreboot/+/47703/3/src/include/device/pci_ids.... 
PS3, Line 459: PCIE_GPP_1
> Since there are multiples of these and it doesn't mean port 1, port 2, etc. […]

good idea

https://review.coreboot.org/c/coreboot/+/47703/3/src/include/device/pci_ids.... 
PS3, Line 492: 0x1617
> 0x1671?

yep, that was a typo