Attention is currently required from: Paul Menzel, Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47223 )
Change subject: nb/intel/haswell/pcie.c: Add missing pre-ASPM init
......................................................................
Patch Set 6:
(1 comment)
File src/northbridge/intel/haswell/pcie.c:
https://review.coreboot.org/c/coreboot/+/47223/comment/d47d49d9_b665aafb
PS6, Line 85: pci_or_config32(dev, PEG_DCAP2, 1 << 19);
This was March 2014, 1.8.0. I'll check if there's an update.
Nothing new. Anyway, if you are sure that other code forces it to 1, that's
ok, just wanted to check.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47223
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dcdd4ca431c2ae1e62f2719c376d8bdef3054bd
Gerrit-Change-Number: 47223
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 26 Feb 2021 22:18:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment