Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32044 )
Change subject: soc/skl: Use devtree options to set primary GPU
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32044/1/src/soc/intel/skylake/romstage/romst...
File src/soc/intel/skylake/romstage/romstage_fsp20.c:
https://review.coreboot.org/#/c/32044/1/src/soc/intel/skylake/romstage/romst...
PS1, Line 280: m_cfg->InternalGfx = 1;
set internalGfx to enabled if PCI 0:2.0 is present and enabled in devicetree.
https://review.coreboot.org/#/c/32044/1/src/soc/intel/skylake/romstage/romst...
PS1, Line 285: m_t_cfg->SkipExtGfxScan = config->SkipExtGfxScan;
SkipExtGfxScan should only be set to 1 on all boards that only use IGD (like chromebooks).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f9362676105e41c69139a094dbb9e8b865689f
Gerrit-Change-Number: 32044
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 27 Mar 2019 11:14:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment