Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27369 )
Change subject: soc/intel/basecode: Add support for updating ucode loaded via FIT ......................................................................
Patch Set 43:
Patch Set 43:
Patch Set 43:
If a patchset doesn't build don't expect somebody to review it. Why is the documentation in a different patch set?
the errors don't seem to be related to this change, will have a look anyways. Will squash the documentation in to this one as well.
i386-elf-ld.bfd: /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_FALCO/bootblock/cpu/intel/microcode/microcode.o: in function `intel_microcode_load_unlocked': /home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/intel/microcode/microcode.c:80: multiple definition of `intel_microcode_load_unlocked'; /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_FALCO/bootblock/cpu/intel/haswell/bootblock.o:/home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/intel/microcode/microcode.c:80: first defined here i386-elf-ld.bfd: /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_FALCO/bootblock/cpu/intel/microcode/microcode.o: in function `get_current_microcode_rev': /home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/intel/microcode/microcode.c:128: multiple definition of `get_current_microcode_rev'; /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_FALCO/bootblock/cpu/intel/haswell/bootblock.o:/home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/intel/microcode/microcode.c:128: first defined here i386-elf-ld.bfd: /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_FALCO/bootblock/cpu/intel/microcode/microcode.o: in function `get_microcode_rev': /home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/intel/microcode/microcode.c:133: multiple definition of `get_microcode_rev'; /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_FALCO/bootblock/cpu/intel/haswell/bootblock.o:/home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/intel/microcode/microcode.c:133: first defined here
Aah, they are because of the previous patch in the train